remove most uses of deprecated v8::PropertyCallbackInfo::This() #6003
Conversation
|
@kentonv ptal - i'm unsure what the consequences of the changes to worker-rpc.c++ are |
Merging this PR will not alter performance
Comparing 
Footnotes
|
|
ok, this latest version seems to work ok. the properties won't show up as own properties. capnweb tests seems to run except for something related to a websocket connection, which i assume is unrelated |
a20439e to
cf1a3aa
Compare
|
i'm going to split out the ugly wildcard property change, since it requires a v8 patch. this takes care of the rest of the This() uses. @jasnell - care to take another look? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6003 +/- ##
=======================================
Coverage 70.37% 70.37%
=======================================
Files 408 408
Lines 108811 108816 +5
Branches 18000 18000
=======================================
+ Hits 76574 76578 +4
Misses 21431 21431
- Partials 10806 10807 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…PECT_PROPERTY Regression test for #4147. Object.getOwnPropertyDescriptors() on a JSG prototype with JSG_INSPECT_PROPERTY used to throw "Illegal invocation" because registerInspectProperty() used SetNativeDataProperty on the prototype. V8 would invoke the native getter callback during descriptor retrieval to produce a data descriptor value, and the callback's HasInstance check would fail because the prototype object is not an instance of the type. Fixed by PR #6003 (c43c98a), which changed registerInspectProperty() to use SetAccessorProperty instead. Assisted-by: Claude
No description provided.