Skip to content

make sure TextDecoder.decode accepts SharedArrayBuffer#5672

Merged
anonrig merged 1 commit intomainfrom
yagiz/accept-shared-array-buffer
Dec 11, 2025
Merged

make sure TextDecoder.decode accepts SharedArrayBuffer#5672
anonrig merged 1 commit intomainfrom
yagiz/accept-shared-array-buffer

Conversation

@anonrig
Copy link
Copy Markdown
Member

@anonrig anonrig commented Dec 10, 2025

Fixes #5388

This change makes sure that we accept SharedArrayBuffer as an input type to TextDecoder.decode().

Failing test file can be found at https://github.com/web-platform-tests/wpt/blob/master/encoding/textdecoder-copy.any.js

@anonrig anonrig requested review from jasnell and npaun December 10, 2025 21:16
@anonrig anonrig requested review from a team as code owners December 10, 2025 21:16
@anonrig anonrig enabled auto-merge (squash) December 10, 2025 21:16
@anonrig anonrig force-pushed the yagiz/accept-shared-array-buffer branch from c5dce19 to a06a65f Compare December 11, 2025 19:55
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Dec 11, 2025

CodSpeed Performance Report

Merging #5672 will improve performances by 14.09%

Comparing yagiz/accept-shared-array-buffer (a06a65f) with main (de9b6d2)

Summary

⚡ 1 improvement
✅ 56 untouched
⏩ 30 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Change
Encode_ASCII_32[TextEncoder][0/0/32] 3.4 ms 3 ms +14.09%

Footnotes

  1. 30 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@anonrig anonrig merged commit f6f6d7a into main Dec 11, 2025
20 of 22 checks passed
@anonrig anonrig deleted the yagiz/accept-shared-array-buffer branch December 11, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate why TextDecoder.decode isn't accepting a SharedArrayBuffer

2 participants