Use ReverseIoOwn in makeReentryCallback().#5655
Merged
Conversation
This ensures resources held by the callback can be freed more proactively when the IoContext shuts down, and also solves an unlikely scenario where the callback outlives the whole isolate (not just the IoContext), leading to a V8 fatal error. This is difficult to reproduce. I have a load test I'm running that usually triggers this after a minute or two, which is obviously not appropriate for a unit test. But this change definitely fixes the problem.
f9e7537 to
d8cf680
Compare
CodSpeed Performance ReportMerging #5655 will improve performances by 13.2%Comparing Summary
Benchmarks breakdown
Footnotes
|
danlapid
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures resources held by the callback can be freed more proactively when the IoContext shuts down, and also solves an unlikely scenario where the callback outlives the whole isolate (not just the IoContext), leading to a V8 fatal error.
This is difficult to reproduce. I have a load test I'm running that usually triggers this after a minute or two, which is obviously not appropriate for a unit test. But this change definitely fixes the problem. (The error doesn't appear ever to have happened in prod.)