Skip to content

Add routingMode option to GetDurableObjectOptions#5525

Closed
MellowYarker wants to merge 1 commit intomainfrom
milan/direct-to-primary
Closed

Add routingMode option to GetDurableObjectOptions#5525
MellowYarker wants to merge 1 commit intomainfrom
milan/direct-to-primary

Conversation

@MellowYarker
Copy link
Copy Markdown
Contributor

@MellowYarker MellowYarker commented Nov 13, 2025

No description provided.

@MellowYarker MellowYarker force-pushed the milan/direct-to-primary branch from 7a08cc7 to d5a16d4 Compare November 13, 2025 20:01
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 13, 2025 •
edited
Loading

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Nov 13, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #5525 will not alter performance

Comparing milan/direct-to-primary (a55afc0) with main (b8755c7)

Summary

✅ 57 untouched
⏩ 30 skipped1

Footnotes

  1. 30 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@MellowYarker MellowYarker force-pushed the milan/direct-to-primary branch from d5a16d4 to a14cc38 Compare November 13, 2025 21:02
@MellowYarker MellowYarker changed the title Add getPrimaryOnly option to GetDurableObjectOptions Add routingMode option to GetDurableObjectOptions Nov 14, 2025
@MellowYarker MellowYarker marked this pull request as ready for review November 14, 2025 14:52
@MellowYarker MellowYarker requested review from a team as code owners November 14, 2025 14:52
@MellowYarker MellowYarker self-assigned this Nov 14, 2025
@MellowYarker MellowYarker force-pushed the milan/direct-to-primary branch 3 times, most recently from 9adef6b to 85c05c0 Compare November 14, 2025 15:52
@MellowYarker MellowYarker requested a review from a team as a code owner November 14, 2025 15:52
@MellowYarker
Copy link
Copy Markdown
Contributor Author

MellowYarker commented Nov 14, 2025

Latest push updates types. Couldn't get just generate-types to just do-what-it's-supposed-to so I manually copied and pasted the expected output. Here's to hoping it works 🤞.

@MellowYarker MellowYarker force-pushed the milan/direct-to-primary branch from 85c05c0 to 3289720 Compare November 14, 2025 16:11
justin-mp
justin-mp approved these changes Nov 20, 2025
View reviewed changes
@MellowYarker MellowYarker force-pushed the milan/direct-to-primary branch from 3289720 to a391748 Compare December 11, 2025 14:08
@MellowYarker MellowYarker force-pushed the milan/direct-to-primary branch from a391748 to a55afc0 Compare December 11, 2025 14:26
@MellowYarker MellowYarker mentioned this pull request Dec 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justin-mp justin-mp justin-mp approved these changes

@lambrospetrou lambrospetrou Awaiting requested review from lambrospetrou

@zachlefevre zachlefevre Awaiting requested review from zachlefevre

Assignees

@MellowYarker MellowYarker

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MellowYarker @justin-mp