Skip to content

Fix UaM in node/process.c++#5483

Merged
fhanau merged 1 commit intomainfrom
felix/110725-fix-uam
Nov 8, 2025
Merged

Fix UaM in node/process.c++#5483
fhanau merged 1 commit intomainfrom
felix/110725-fix-uam

Conversation

@fhanau
Copy link
Contributor

@fhanau fhanau commented Nov 8, 2025

No description provided.

@fhanau fhanau requested a review from anonrig November 8, 2025 04:05
@fhanau fhanau requested review from a team as code owners November 8, 2025 04:05
@fhanau fhanau requested a review from a team November 8, 2025 04:05
@fhanau fhanau requested a review from a team as a code owner November 8, 2025 04:05
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 8, 2025

CodSpeed Performance Report

Merging #5483 will not alter performance

Comparing felix/110725-fix-uam (d830caf) with main (23b7483)

Summary

✅ 34 untouched
⏩ 9 skipped1

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a test that verifies this, so we don't regress?

@fhanau
Copy link
Contributor Author

fhanau commented Nov 8, 2025

is there a test that verifies this, so we don't regress?

I found this using Clang Static Analyzer's cplusplus.Move check, but that is very slow and has several false positives in our code base, so not something we can enable in CI. We do have a clang-tidy check enabled that's also supposed to find UaM, but that wasn't sufficient here. Effectively, we don't have a way to avoid this except for good test coverage and careful PR reviews.

@fhanau fhanau merged commit 466ef28 into main Nov 8, 2025
42 of 45 checks passed
@fhanau fhanau deleted the felix/110725-fix-uam branch November 8, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants