Skip to content

fixing benchmarks setup#5472

Merged
mikea merged 1 commit intomainfrom
maizatskyi/2025-11-06-bench-bazel-test
Nov 7, 2025
Merged

fixing benchmarks setup#5472
mikea merged 1 commit intomainfrom
maizatskyi/2025-11-06-bench-bazel-test

Conversation

@mikea
Copy link
Contributor

@mikea mikea commented Nov 6, 2025

  • no more weird filegroup
  • benchmarks are run as part of bazel test
  • min time is specified only in actual benchmarking run

@mikea mikea requested a review from anonrig November 6, 2025 16:59
@mikea mikea requested review from a team as code owners November 6, 2025 16:59
@mikea mikea force-pushed the maizatskyi/2025-11-06-bench-bazel-test branch 2 times, most recently from 2f02341 to 7700e1e Compare November 6, 2025 18:17
@mikea mikea force-pushed the maizatskyi/2025-11-06-bench-bazel-test branch 2 times, most recently from 04c9331 to 6f0459d Compare November 6, 2025 22:52
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 7, 2025

CodSpeed Performance Report

Merging #5472 will not alter performance

Comparing maizatskyi/2025-11-06-bench-bazel-test (3a338bf) with main (cde6ad0)

Summary

✅ 34 untouched
⏩ 9 skipped1

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@art049
Copy link

art049 commented Nov 7, 2025

Unable to generate the performance report

There was an internal error while processing the run's data. We're working on fixing the issue. Feel free to contact us on Discord or at support@codspeed.io if the issue persists.

the error is related to the following command running: /bin/sed -E -e s/.**/& /g -e s/(([ -]|[�-�][�-�]|[�-�][�-�][�-�]|[�][�-�][�-�]|[�-�][�-�][�-�]|[�][�-�][�-�][�-�])**)./\\1?/g -e s/(.*)\\?/\\1/g -e s|]]>|]]>]]<![CDATA[>|g

It breaks the parsing on our end, we'll fix this asap. In the meantime, if you find a way to run without it, it should restore the reports. Sorry for the inconvenience.

- no more weird filegroup
- benchmarks are run as part of bazel test
@mikea mikea force-pushed the maizatskyi/2025-11-06-bench-bazel-test branch 2 times, most recently from 6e548fb to 3a338bf Compare November 7, 2025 20:18
@mikea
Copy link
Contributor Author

mikea commented Nov 7, 2025

Thanks for taking a look @art049

In the meantime, if you find a way to run without it, it should restore the reports.

Sorry, it is not very clear: is this command under our control? I can't find it. What do you mean to run without it?

@mikea mikea merged commit 86b9649 into main Nov 7, 2025
20 of 21 checks passed
@mikea mikea deleted the maizatskyi/2025-11-06-bench-bazel-test branch November 7, 2025 22:09
@art049
Copy link

art049 commented Nov 7, 2025

It's running under the bazel command, running the benchmarks so I guess it is yes. We're tracing that command during the execution. Maybe it's created indirectly by Bazel. Something must have changed in the way the benchmarks are run, making this issue appear. Should be fixed by Monday anyway.

GuillaumeLagrange added a commit to AvalancheHQ/workerd that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants