Fix ctx.id.name for Durable Objects to match production.#4351
Merged
Conversation
anonrig
reviewed
Jun 17, 2025
MellowYarker
approved these changes
Jun 17, 2025
In prdouction, ctx.id.name is not available. We wish it were, but there are reasons why it's not easy to do. See #2240 A recent refactoring of workerd accidentally made `ctx.id.name` available in local testing. This was not intended, as it doesn't match production. This commit removes the name, to match production behavior.
f0c3a49 to
862e9d6
Compare
lukevalenta
added a commit
to cloudflare/azul
that referenced
this pull request
Jul 10, 2025
Unfortunately, we can't use ctx.id.name to find a Durable Object's name within the DO itself (this previously worked only for local testing, but has been removed: cloudflare/workerd#4351). Instead, we can iterate over all possible names for the durable object based on the app configuration until we find the correct one. Also, clean up some clippy lint complaints.
lukevalenta
added a commit
to cloudflare/azul
that referenced
this pull request
Jul 10, 2025
Unfortunately, we can't use ctx.id.name to find a Durable Object's name within the DO itself (this previously worked only for local testing, but has been removed: cloudflare/workerd#4351). Instead, we can iterate over all possible names for the durable object based on the app configuration until we find the correct one. Also, clean up some clippy lint complaints.
lukevalenta
added a commit
to cloudflare/azul
that referenced
this pull request
Jul 10, 2025
Unfortunately, we can't use ctx.id.name to find a Durable Object's name within the DO itself (this previously worked only for local testing, but has been removed: cloudflare/workerd#4351). Instead, we can iterate over all possible names for the durable object based on the app configuration until we find the correct one. Also, clean up some clippy lint complaints.
sys-ravenmki98
added a commit
to sys-ravenmki98/azul
that referenced
this pull request
Sep 29, 2025
Unfortunately, we can't use ctx.id.name to find a Durable Object's name within the DO itself (this previously worked only for local testing, but has been removed: cloudflare/workerd#4351). Instead, we can iterate over all possible names for the durable object based on the app configuration until we find the correct one. Also, clean up some clippy lint complaints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In prdouction, ctx.id.name is not available. We wish it were, but there are reasons why it's not easy to do. See #2240
A recent refactoring of workerd accidentally made
ctx.id.nameavailable in local testing. This was not intended, as it doesn't match production. This commit removes the name, to match production behavior.