Containers: wait for up/down streams to finish resolving the connectImpl promise#3437
Merged
kentonv merged 1 commit intocloudflare:mainfrom Jan 30, 2025
Merged
Containers: wait for up/down streams to finish resolving the connectImpl promise#3437kentonv merged 1 commit intocloudflare:mainfrom
kentonv merged 1 commit intocloudflare:mainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
recheck |
jasnell
approved these changes
Jan 29, 2025
kentonv
approved these changes
Jan 30, 2025
Member
kentonv
left a comment
There was a problem hiding this comment.
Looks good but we need to verify whether the internal tests pass with this. I think they should but not 100% sure. Can you open an internal PR that updates the submodule dep, in order to run this through CI?
…mpl promise @kenton suggested adding this line to fix the issues we were finding with the containers integration.
Contributor
Author
|
rebased |
Member
|
Internal CI passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kenton suggested adding this line to fix the issues we were finding with the containers integration. Seems to be fixing all of the problems we were finding!