Skip to content

feat: workflow types support generic params#3167

Merged
sidharthachatterjee merged 1 commit intocloudflare:mainfrom
dh94:workflow-types-support-generic-params
Nov 29, 2024
Merged

feat: workflow types support generic params#3167
sidharthachatterjee merged 1 commit intocloudflare:mainfrom
dh94:workflow-types-support-generic-params

Conversation

@dh94
Copy link
Contributor

@dh94 dh94 commented Nov 25, 2024

Improves types usability, instead of writing

type Env {
   MY_WORKFLOW: Workflow;
}

// ... some logic in other file
env.MY_WORKFLOW.create({
  params: {
     some_param: 1
   } as MyWorkflowParams
 });

We could do something like

type Env {
   MY_WORKFLOW: Workflow<MyWorkflowParams>;
}

// ... some logic in other file
env.MY_WORKFLOW.create({
  params: {
     some_param: 1
   }
});

@dh94 dh94 requested review from a team as code owners November 25, 2024 15:13
@dh94 dh94 requested review from anonrig and mar-cf November 25, 2024 15:13
@github-actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@dh94
Copy link
Contributor Author

dh94 commented Nov 25, 2024

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Nov 25, 2024
@github-actions
@dh94 has signed the CLA in #3167
960cc16
@dh94
Copy link
Contributor Author

dh94 commented Nov 26, 2024

not sure what to do with the failed CI check, seems unrelated 😅

@elithrar elithrar mentioned this pull request Nov 26, 2024
Merged
3 tasks
@sidharthachatterjee
Copy link
Contributor

sidharthachatterjee commented Nov 29, 2024

Thanks @dh94

Yeah, that's unrelated. Merging in. Thanks!

@sidharthachatterjee sidharthachatterjee merged commit 410b59c into cloudflare:main Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

@mar-cf mar-cf Awaiting requested review from mar-cf mar-cf is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dh94 @sidharthachatterjee @jasnell @anonrig