Merged
Conversation
fhanau
approved these changes
May 31, 2024
This is a bit of a random drive-by optimization. I noticed that the R2Bucket `Checksums` class was unnecessarily performing multiple heap allocations and copies when it could be implemented with stack allocation and a single copy. In reality, the `Checksums` class really could have been a struct given how it is used but that would possibly be a breaking change :-/
fd8dfd4 to
0607352
Compare
jasnell
added a commit
that referenced
this pull request
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of a random drive-by optimization. I noticed that the R2Bucket
Checksumsclass was unnecessarily performing multiple heap allocations and copies when it could be implemented with stack allocation and a single copy. This does end up making instances ofChecksumslightly larger but reduces the number of small heap allocations and copies.In reality, the
Checksumsclass really could have been a struct given how it is used but that would possibly be a breaking change :-/