Merged
Conversation
|
southpolesteve
added a commit
that referenced
this pull request
Feb 27, 2026
15 Playwright E2E tests covering the full ISR lifecycle: - MISS on first request with X-Vinext-Cache header - HIT on second request within TTL (same timestamp) - STALE after TTL expires (same cached content) - HIT after background regeneration completes - Cache-Control with s-maxage and stale-while-revalidate - Non-ISR pages have no ISR headers - Browser rendering of ISR pages Also documents ISR background regen bug in DISCOVERIES.md: Pages Router regen re-caches old HTML instead of re-rendering.
5 tasks
james-elicx
added a commit
to NathanDrake2406/vinext
that referenced
this pull request
Mar 12, 2026
- Bug cloudflare#2: hybrid build skipped Pages Router pre-rendering when App Router entry also present — fix: only bail out on pure App Router builds (no pages entry) - Bug #1: getOutputPath traversal guard bypassed on Windows by backslash urlPath — fix: reject urlPath containing backslashes before posix normalize - Bug cloudflare#4: double-counting in result.skipped when AbortController fires and res.text() throws — fix: replace await res.text() with res.body?.cancel() - Bug cloudflare#6: dynamic routes without getStaticPaths/generateStaticParams classified as 'ssr' — fix: use 'unknown' (skipped for unenumerable params, not SSR APIs) - Bug cloudflare#3: routes that throw in ssrLoadModule silently omitted from routeClassifications — fix: wrap in try/catch, add 'unknown' classification - Bug cloudflare#5: buildReportRows ignored knownRoutes for API routes — fix: check known?.get(route.pattern) first, fall back to 'api' - Bug cloudflare#7: dead !Array.isArray guard after try/catch in expandDynamicAppRoute — remove unreachable branch - Bug cloudflare#8: middlewareHeaders spread onto 200 pre-rendered response could include Location header — fix: filter out 'location' before spreading - Bug cloudflare#9: configOverride typed as Partial<NextConfig> allows unsafe non-scalar fields — narrow to Pick<NextConfig, 'output' | 'trailingSlash'>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dist/cli.jsinstead of./dist/cli.js)Includes Sunil's three fixes: optimizeDeps exclusion (#3), inline sourcemaps (#5), and dynamic
"use client"(#7).