Make virtio-vsock hotpluggable/unpluggable #1084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible to have multiple vsock devices so in preparation for hotplug/unplug it is important to be able to have a unique identifier for each device. Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com> Signed-off-by: Rob Bradford <robert.bradford@intel.com>
This means it can be reused with ch-remote. Signed-off-by: Rob Bradford <robert.bradford@intel.com>
Create a new VirtioVsock device and add it to the PCI bus upon hotplug. Signed-off-by: Rob Bradford <robert.bradford@intel.com>
Add the vsock device to the device manager and patch the config to add the new vsock device. Signed-off-by: Rob Bradford <robert.bradford@intel.com>
When doing device unplug remove the vsock device from the configuration if present. Signed-off-by: Rob Bradford <robert.bradford@intel.com>
Signed-off-by: Rob Bradford <robert.bradford@intel.com>
This allows the hotplugging of vsock devices. Signed-off-by: Rob Bradford <robert.bradford@intel.com>
Add support for adding a vsock device using the HTTP API. Signed-off-by: Rob Bradford <robert.bradford@intel.com>
Test basic vsock functionality works with hotplugged vsock device. Signed-off-by: Rob Bradford <robert.bradford@intel.com>
3c2590c to
a5bb1e0
Compare
sboeuf
approved these changes
Apr 29, 2020
likebreath
added a commit
to likebreath/cloud-hypervisor
that referenced
this pull request
Jul 16, 2020
With recent changes (cloud-hypervisor#1030 cloud-hypervisor#1084), the '/vm.remove-device' API is no longer restricted to remove VFIO PCI devices. It now supports (almost) all hotpluggable devices, e.g. disk/net/pmem/fs/vsock. Signed-off-by: Bo Chen <chen.bo@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support adding at most one virtio-vsock device.