Skip to content

Improve VNet CIDR management for GCP/IBM#2364

Merged
cb-github-robot merged 1 commit intocloud-barista:mainfrom
yunkon-kim:260312-10
Mar 12, 2026
Merged

Improve VNet CIDR management for GCP/IBM#2364
cb-github-robot merged 1 commit intocloud-barista:mainfrom
yunkon-kim:260312-10

Conversation

@yunkon-kim
Copy link
Copy Markdown
Member

@yunkon-kim yunkon-kim commented Mar 12, 2026

This PR improves VNet CIDR management for GCP/IBM.

This will stabilize multi-cloud resource provisioning for GCP and IBM and resolve VNet creation hangs caused by missing CSP metadata.

Tumblebug will intentionally manage the user-provided vNet CIDR block as metadata, although CSPs (e.g., GCP, IBM) do not natively support vNet (VPC) CIDR blocks.

Note - From a management perspective, this helps users (e.g., admin, network operator) easily manage network addresses and prevent errors during resource creation on different cloud platforms.

Improvements

  • Set user-provided CIDR for GCP and IBM to handle cases where the CSP doesn't support it
  • Fix missing ConnectionConfig on Subnet objects when creating vNet and subnets together
  • Add name validation for subnets

Test environment

  • Spider v0.12.7 -> v0.12.8
    • Note: potential compatibility issues identified with v0.12.8; further verification required.

Before and after

  • GCP

    • Before: vNetInfo.cidrBlock: "GCP VPC does not support IPv4_CIDR"
    • After: vNetInfo.cidrBlock: "10.0.0.0/16"
  • IBM

    • Before: vNetInfo.cidrBlock: "IBM VPC does not support IPv4_CIDR"
    • After: vNetInfo.cidrBlock: "10.0.0.0/16"
  • Note - I'd like to skip to show the ConnectionConfig info of subnets ;)

References

* Set user-provided CIDR for GCP and IBM to handle cases where the CSP doesn't support it
* Fix missing ConnectionConfig on Subnet objects when creating vNet and subnets together
@yunkon-kim yunkon-kim requested a review from seokho-son as a code owner March 12, 2026 04:42
@seokho-son
Copy link
Copy Markdown
Member

/hold

@github-actions github-actions bot added the hold Need to hold merge label Mar 12, 2026
@seokho-son
Copy link
Copy Markdown
Member

seokho-son commented Mar 12, 2026

Hi @yunkon-kim
Thanks for update! LGTM.

But, we need to complete test with Spider v0.12.8 since it is our current base is https://github.com/cloud-barista/cb-tumblebug/blob/main/docker-compose.yaml#L166

Please share the testing result of this PR based on the CB-TB latest commit (Spider v0.12.8)

@yunkon-kim
Copy link
Copy Markdown
Member Author

yunkon-kim commented Mar 12, 2026

@seokho-son

Tests with Spider v0.12.8 passed as follows.
image

(Note - previously, there was an issue with v0.12.8 when running on all systems where certain files/information were inaccessible. The issue was not observed in this test. I will report back next time I observe it.)

@seokho-son
Copy link
Copy Markdown
Member

/hold cancel

@github-actions github-actions bot removed the hold Need to hold merge label Mar 12, 2026
@seokho-son
Copy link
Copy Markdown
Member

@yunkon-kim I guess your previous failure was based on missed configuration in the upstream while updating cb-spider version from v0.12.7 to v0.12.8 (this version includes several configuration changes. also, I heard there is a mistake within cb-spider)

I think the current cb-tb latest commit would be fine. :)
Anyway, let me know if you experience any other problems!

@seokho-son
Copy link
Copy Markdown
Member

/approve

@github-actions github-actions bot added the approved This PR is approved and will be merged soon. label Mar 12, 2026
@cb-github-robot cb-github-robot merged commit 516b19b into cloud-barista:main Mar 12, 2026
4 checks passed
@yunkon-kim yunkon-kim deleted the 260312-10 branch March 17, 2026 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved This PR is approved and will be merged soon.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants