[IBM] Fix subnet's prefix issue#1591
Merged
cb-spider merged 4 commits intocloud-barista:masterfrom Oct 17, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses IBM VPC subnet prefix handling issues by:
- Disabling VPC CIDR capability for IBM driver
- Creating subnet-specific address prefixes with CIDR matching the subnet
- Removing address prefixes when subnets are deleted
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| VPCHandler.go | Updated to create/delete address prefixes per subnet; disabled VPC-level CIDR support; added cleanup logic for prefixes during subnet/VPC deletion |
| IBMCloudDriver.go | Disabled VPC_CIDR capability flag for IBM driver |
| Test_Resources.go | Added missing boolean parameter to GetPriceInfo call |
| config.yaml.sample | Fixed YAML structure for subnetIID from list to single object |
powerkimhub
approved these changes
Oct 17, 2025
cb-spider
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IBM