Add more specific host checks to gh attestation commands
#8948
Conversation
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
…s/cli into gh-attestation-support-ghe-hosts
Signed-off-by: Meredith Lancaster <malancas@github.com>
|
Did you copy these because they were unexported? Cause they are probably going to be exported: cli/go-gh#152 |
|
Yeesh sorry @malancas I totally did you wrong by not reading your PR description which I basically unintentionally answered in my last comment. FWIW I think these are also already in Is there anything missing? |
No worries. I'll just wait until cli/go-gh#152 is merged and update this to use the exported functions. |
|
Reiterating, these functions are already in cli/internal/ghinstance/host.go Lines 24 to 33 in 156a697 |
|
@phillmv I believe you had some opinions about this. Do you want this in before the release today? It doesn't appear complicated to use what is already in |
This adds more specific client host checking to the
attestationcommand set. The functions used here are copied from cli/go-gh. If we are happy with this approach, I will look into whether we can export the functions in cli/go-gh and replace this custom code with those exported functions.