Allow reuse of host checks for extension authors#152
Merged
andyfeller merged 6 commits intotrunkfrom Apr 29, 2024
Merged
Conversation
Following on the heels of #151, this commit exports the internal logic used to determine if a host is GHES deployment or a tenant. Exporting these functions allow extension authors like `github/gh-copilot` to provide tailored experiences consistently with `gh`.
This aligns the `cli/cli` behavior of IsTenancy and IsEnterprise with the counterparts here.
Contributor
Author
|
From @williammartin:
|
Including API cases for tenancy checks, ensuring that hosts are normalized.
Adding API hosts to TestIsEnterprise to ensure that normalized hosts work as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on the heels of #151, this commit exports the internal logic used to determine if a host is GHES deployment or a tenant.
Exporting these functions allow extension authors like
github/gh-copilotto provide tailored experiences consistently withgh.