fix: make number arg, commit arg, and flags mutually exclusive#7268
Merged
fix: make number arg, commit arg, and flags mutually exclusive#7268
Conversation
samcoe
suggested changes
Apr 4, 2023
pkg/cmd/browse/browse.go
Outdated
Comment on lines
+116
to
+118
| "specify only one of `number arg`, `commit SHA arg`, `--branch`, `--commit`, `--projects`, `--releases`, `--settings`, or `--wiki`", | ||
| isNumber(opts.SelectorArg), | ||
| isCommit(opts.SelectorArg), |
Contributor
There was a problem hiding this comment.
I feel like this error message and error condition is getting quiet long and convoluted. I would rather see this new error condition broken out into its own check with a nicer error message for the user. Something like:
if (isNumber(opts.SelectorArg) || isCommit(opts.SelectorArg)) && (opts.Branch != "" || opts.Commit != "") {
return cmdutil.FlagErrorf("%q is an invalid argument when using `--branch` or `--commit`", opts.SelectorArg)
}
Contributor
There was a problem hiding this comment.
this would make for a nicer experience and i hastily reviewed before seeing sam's comment; I'm +1 on this change before merging.
Contributor
Author
There was a problem hiding this comment.
Thank you for review.
Indeed, I broke the condition into the args own.
vilmibm
approved these changes
Apr 4, 2023
jtpetty
pushed a commit
that referenced
this pull request
May 22, 2023
* make number, commit, and flags mutually exclusive * break condition into arg own check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7266