fix: throw error for non-existing org / repo with non-zero status in repo list#7240
Merged
fix: throw error for non-existing org / repo with non-zero status in repo list#7240
Conversation
mislav
suggested changes
Mar 28, 2023
Contributor
mislav
left a comment
There was a problem hiding this comment.
Hi, this is a good start! Some important notes follow
|
Are there no additional test cases to accompany this change ? Are there any test cases for CLI ? |
Contributor
|
@ianwilliams1 Good point; I've forgot to ask the submitter for a test. I've added one in a followup PR 🙇 |
Contributor
Author
|
After Mislav's comments, I've revised the test locally but haven't committed it since it was still in WIP. Should've changed the PR to draft. Sorry about that. Since he's made it already, I'll discard my local change then. |
jtpetty
pushed a commit
that referenced
this pull request
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #7231