Bump github.com/spf13/cobra from v1.4.0 to v1.5.0#6196
Merged
Conversation
Cobra v1.5.0 contains a fix for the zsh autocompletion #compdef line to only complete <command>, not _<command> (the completion function itself), see spf13/cobra#1690 TestNewCmdCompletion for zsh is updated accordingly.
Collaborator
|
Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message. |
samcoe
approved these changes
Sep 6, 2022
ottok
pushed a commit
to ottok/github-cli
that referenced
this pull request
Dec 29, 2024
Cobra v1.5.0 contains a fix for the zsh autocompletion #compdef line to only complete <command>, not _<command> the completion function itself, See cli#6196 TestNewCmdCompletion for zsh, which checks that #compdef line, is updated accordingly. Fixes FTBFS with golang-github-spf13-cobra-dev (>= 1.5.0) Thanks: Shengjing Zhu for reporting the issue. Closes: #1019137
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cobra v1.5.0 contains a fix for the zsh autocompletion
#compdefline to only complete<command>, not_<command>(the completion function itself), see spf13/cobra#1690TestNewCmdCompletion for zsh is updated accordingly.
Thanks to @zhsj for discovering the FTBFS (fail to build from source) bug in Debian where golang-github-spf13-cobra-dev was updated to 1.5.0 some time ago, see https://bugs.debian.org/1019137