Add --clobber / --skip-existing to run download and release download#6053
Merged
Add --clobber / --skip-existing to run download and release download#6053
--clobber / --skip-existing to run download and release download#6053Conversation
9ec5547 to
8a00d54
Compare
samcoe
approved these changes
Sep 1, 2022
Contributor
samcoe
left a comment
There was a problem hiding this comment.
@satotake Thanks for the contribution. I went ahead and added a couple commits on top of your work making slight modifications.
- I reduced the scope of the PR store just address
release downloadsince that is what was requested in the original issue. - I changed the logic to only perform the download when we knew we would write the file or if download the release source archive, hopefully saving our users from downloading extra data that would just be discarded.
scottclk
added a commit
to scottclk/cli
that referenced
this pull request
Jan 29, 2025
This functionality already exists for release download. It was initally added in the same PR cli#6053 but the changes were overwritten by a further commit. Makes it possible to skip when the file already exists or overwriting existing files when required.
This was referenced Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2598
--clobbertorun download--clobbertorelease download--skip-existingtorun download--skip-existingtorelease download