Fix determining the current executable under Homebrew for Linux#5822
Merged
Fix determining the current executable under Homebrew for Linux#5822
Conversation
We need to use `os.Lstat` instead of `os.Stat` if we are going to manually inspect files for whether they are a symlink. On macOS, it looks like `os.Stat` returns information about the symlink itself.
samcoe
approved these changes
Jun 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to use
os.Lstatinstead ofos.Statif we are going to manually inspect files for whether they are a symlink.On macOS, it looks likeI was wrong, oros.Statreturns information about the symlink itself.os.Statused to work differently in older versions of Go.Fixes #5428
Followup to #4243