Add preliminary `repo create` command by mislav · Pull Request #547 · cli/cli

mislav · 2020-02-25T17:11:42Z

Create a new GitHub repository.

Usage:
  gh repo create [<name>] [flags]

Flags:
      --public   Make the new repository public

Global Flags:
      --help              Show help for command
  -R, --repo OWNER/REPO   Select another repository using the OWNER/REPO format

TODO:

Add a git remote for the new repo
Add ability to specify the org owner for the repo
- Add ability to specify org team that should be granted access
Set description, homepage fields
Add flag for hasIssuesEnabled?
Add flag for hasWikiEnabled?

Discuss:

If the name for the repo wasn't given, the top-level project directory name is used instead. Is this a good default?
Should we automatically add a git remote for the new repository upon successful repo create?
What should happen if repo create was run in a context outside of a local git repository?
If we allow specifying an organization + team for the new repo, what should the interface for that look like?
Should we support disabling issues/wiki in the new repo?
Should we support creating repositories from template repos? If so, how would that usage differ from regular usage?

Fixes #300

vilmibm · 2020-02-25T17:23:40Z

If the name for the repo wasn't given, the top-level project directory name is used instead. Is this a good default?

I like this.

Should we automatically add a git remote for the new repository upon successful repo create?

My gut says no; I'm not sure when this would be useful?

What should happen if repo create was run in a context outside of a local git repository?

User is asked if they'd like to clone the repo (like what I'm doing in #549).

If we allow specifying an organization + team for the new repo, what should the interface for that look like?

Org seems like it could be specified by passing the repo name explicitly in the form OWNER/REPO. Teams I think would have to be a string slice argument of team names?

Should we allow disabling issues/wiki in the new repo?

I like the idea of having flags for this but it could also be follow up work.

mislav · 2020-02-25T17:32:31Z

Should we automatically add a git remote for the new repository upon successful repo create?

My gut says no; I'm not sure when this would be useful?

# in a new project:
git init
# add some commits...
gh repo create
git push -u origin master

User is asked if they'd like to clone the repo

A new GitHub repository is empty; there is nothing to clone 🤔

vilmibm · 2020-02-25T19:07:15Z

@mislav i don't know why i didn't think of the new project case 🤦‍♀️ i do think we should automatically add a remote, yes.

A new GitHub repository is empty; there is nothing to clone

wouldn't a directory with a .git be set up so they can start committing? or am i misunderstanding?

ampinsk · 2020-02-26T18:44:53Z

If the name for the repo wasn't given, the top-level project directory name is used instead. Is this a good default?

Yes, totally reasonable!

Should we automatically add a git remote for the new repository upon successful repo create?

I am leaning towards yes here

What should happen if repo create was run in a context outside of a local git repository?

I kind of like the idea of us running git init if they haven't yet, but I think that's really risky. It's probably safest to error for now.

If we allow specifying an organization + team for the new repo, what should the interface for that look like?

Agree that this seems implicit in passing OWNER/REPO? I might not understand the case you're talking about fully.

Should we support disabling issues/wiki in the new repo?
Should we support creating repositories from template repos? If so, how would that usage differ from regular usage?

I think these can both be follow up items 👍

mislav · 2020-02-26T18:56:03Z

Added support for more repository fields:

Create a new GitHub repository.

Usage:
  gh repo create [<name>] [flags]

Flags:
  -d, --description string   Description of repository
      --enable-issues        Enable issues in the new repository (default true)
      --enable-wiki          Enable wiki in the new repository (default true)
  -h, --homepage string      Repository home page URL
      --public               Make the new repository public

To complete this PR, working on organization repo support and covering the case of this command being run outside of the context of an existing git repository.

mislav · 2020-03-03T20:52:56Z

Added support for orgs:

Create a new GitHub repository.

Use the "ORG/NAME" syntax to create a repository within your organization.

Usage:
  gh repo create [<name>] [flags]

Flags:
  -d, --description string   Description of repository
      --enable-issues        Enable issues in the new repository (default true)
      --enable-wiki          Enable wiki in the new repository (default true)
  -h, --homepage string      Repository home page URL
      --public               Make the new repository public
  -t, --team string          The name of the organization team to be granted access

Global Flags:
      --help              Show help for command
  -R, --repo OWNER/REPO   Select another repository using the OWNER/REPO format

API v3 is used due to GraphQL equivalents needing additional read:org OAuth scope to resolve org/team names to GraphQL node IDs.

Additionally, when this command is ran from outside of a git repo, it prompts to set up a new git directory for the new GitHub repo.

vilmibm

there is definitely follow up work I want to see but there's nothing I'm not comfortable with us shipping as it is.

vilmibm · 2020-03-03T21:16:40Z

command/repo.go

+		isTTY = utils.IsTerminal(outFile)
+		if isTTY {
+			// FIXME: duplicates colorableOut
+			out = utils.NewColorable(outFile)


I do want to see this cleaned up and better abstracted but am ok with that being follow-up work

vilmibm · 2020-03-03T21:29:32Z

command/repo.go

+		}
+	} else if isTTY {
+		doSetup := false
+		// TODO: use overridable Confirm


given that i added that in repo fork i'm ok with follow-up work increasing test coverage one all the repo stuff is in.

Yes, that's what the TODO work is all about. Furthermore, I only activate prompts if stdout is a tty (come to think of it, we should also check if stdin is tty, otherwise prompts won't work), and currently we don't have a way of emulating a tty in tests.

Add preliminary repo create command

9175fc0

vilmibm mentioned this pull request Feb 26, 2020

WIP add create repo #343

Closed

Accept more repo fields via flags to repo create

b02dac8

mislav added 2 commits February 26, 2020 19:53

Automatically add origin remote after repo create

4a56280

Have correct command be run in repo clone test

4e97a0e

mislav added 2 commits March 3, 2020 21:07

repo create NAME offers to set up when ran outside of a git repo

8deb0d8

Add ability to repo create within an org

be09717

mislav marked this pull request as ready for review March 3, 2020 20:50

mislav requested a review from vilmibm March 3, 2020 20:53

vilmibm approved these changes Mar 3, 2020

View reviewed changes

mislav added 3 commits March 3, 2020 22:55

Merge remote-tracking branch 'origin/master' into repo-create

52cc04e

Tweak repo docs

15b758a

Use overridable Confirm

74cd5b3

mislav merged commit 6c2328b into master Mar 3, 2020

mislav deleted the repo-create branch March 3, 2020 22:05

mislav mentioned this pull request Mar 9, 2020

Fix setting homepage URL in repo create #617

Merged

mislav mentioned this pull request Oct 13, 2020

Known problems with repo create command #2184

Closed

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add preliminary `repo create` command#547

Add preliminary `repo create` command#547
mislav merged 9 commits intomasterfrom
repo-create

mislav commented Feb 25, 2020 •

edited

Loading

Uh oh!

vilmibm commented Feb 25, 2020

Uh oh!

mislav commented Feb 25, 2020 •

edited

Loading

Uh oh!

vilmibm commented Feb 25, 2020

Uh oh!

ampinsk commented Feb 26, 2020 •

edited

Loading

Uh oh!

mislav commented Feb 26, 2020

Uh oh!

mislav commented Mar 3, 2020

Uh oh!

vilmibm left a comment

Uh oh!

vilmibm Mar 3, 2020

Uh oh!

vilmibm Mar 3, 2020

Uh oh!

mislav Mar 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mislav commented Feb 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vilmibm commented Feb 25, 2020

Uh oh!

mislav commented Feb 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vilmibm commented Feb 25, 2020

Uh oh!

ampinsk commented Feb 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mislav commented Feb 26, 2020

Uh oh!

mislav commented Mar 3, 2020

Uh oh!

vilmibm left a comment

Choose a reason for hiding this comment

Uh oh!

vilmibm Mar 3, 2020

Choose a reason for hiding this comment

Uh oh!

vilmibm Mar 3, 2020

Choose a reason for hiding this comment

Uh oh!

mislav Mar 3, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mislav commented Feb 25, 2020 •

edited

Loading

mislav commented Feb 25, 2020 •

edited

Loading

ampinsk commented Feb 26, 2020 •

edited

Loading