feat: add job id, into run view suggest command#5105
Merged
Conversation
Contributor
Author
|
CI failed... Is it because I wrote |
Contributor
Author
samcoe
approved these changes
Jan 27, 2022
Contributor
There was a problem hiding this comment.
@yasudanaoya Thanks for the contribution. Code looks good to me. I pushed one small change to use "the" instead of "a" when referencing a single job.
The reason the actions did not run is because we have some protection in the repo preventing actions from running for first time contributors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed to display job id in advance in the suggestion command displayed when
gh run viewis executed.Previously, the user had to copy and paste the suggested command and the target job id.
I wanted to complete it only once
However, only when there is one job.
When displaying all jobs, the same ones as before are displayed.