Allow PR create to create PRs with numerical branch names#5090
Merged
Conversation
mislav
approved these changes
Jan 24, 2022
Contributor
mislav
left a comment
There was a problem hiding this comment.
Awesome; thank you for a straightforward solution and for documenting the hack really well for future generations!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a special case for the
pr createcommand so that it can create PRs on branches that have numerical names. It adds a special case to the pull request finder where if theBaseBranchoption is specified then always interpret theSelectoroption as a branch name rather than a potential PR number. Thepr createcommand is the only command that uses theBaseBranchoption functionality.Closes #3885