Dont execute jq filters or templates when api requests are not successful#5088
Merged
Dont execute jq filters or templates when api requests are not successful#5088
Conversation
Contributor
|
@chadwhitacre Sorry about that! For what it's worth, the original behavior was a bug: the jq filter should have never been applied to the HTTP 404 response (and thus mask the error response). The new behavior of dumping error JSON output to stdout isn't great either; I'll open an issue about this. |
jimmidyson
added a commit
to mesosphere/kind-docker-image-automation
that referenced
this pull request
Sep 18, 2022
Since cli/cli#5088, `gh` no longer passes error output to jq filter so instead pass the stdout to a jq invocation. This prevents triggering image builds for invalid tags.
jimmidyson
added a commit
to mesosphere/kind-docker-image-automation
that referenced
this pull request
Sep 18, 2022
Since cli/cli#5088, `gh` no longer passes error output to jq filter so instead pass the stdout to a jq invocation. This prevents triggering image builds for invalid tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the
apicommand to no longer attempt to filter or execute templates when the API request was not successful, now the API error message will be displayed instead of failure messages from the filter or template.Closes #4255