Made check symbol for cancelled uniform across commands#4850
Made check symbol for cancelled uniform across commands#4850
Conversation
|
@bchadwic Hey! We discussed this in a triage call & think that the existing categorization actually makes a bit more sense given that a "CANCELLED" workflow/action results in a failure for PRs. Going to close this for now unless you feel strongly otherwise & we can reopen discussion or try to find a nuanced way to display cancellations vs. failures. |
|
@bchadwic I realize that our decision here kind of overrides the suggestion you got in #4090 (review), but we've thought this through and concluded that as long as "cancelled" counts as a failure on the platform, we're much more comfortable with it being rendered and reported as a failure rather than it being rendered and counted together with neutral statuses like "skipped". Instead, would you be open to changing |
Yeah, definitely! Making the checks uniform was my main concern, whether "cancelled" is "X" or "-" doesn't bother me a bit. Out of curiosity though, what scenario does "cancelled" happen? Is it user driven or something on the backend? Also, @darcyclarke, can we open this pr back up with the intent to change |
|
Workflow runs may be cancelled via the API, via the web UI while a workflow is running, or by the Actions infrastructure itself (by default, one failed job in a matrix will auto-cancel all other running jobs in that matrix). |
mislav
left a comment
There was a problem hiding this comment.
Note that this UI change comes with a behavior change: a "cancelled" job will make gh pr checks return a nonzero exit status. I'm fine with this, as I see it that "cancelled" being a neutral status before was a bug.
Mentioned in #4090
Meant to get to this a while ago, the
CANCELLEDstatus for a check is either aXor a-, depending on what command you use.With this pr, regardless of the command,
-is the symbol for checks with aCANCELLEDstatus