Skip to content

[Bug fix] gh pr merge fails to delete remote branch if $PWD is not a git repository#4769

Merged
mislav merged 4 commits intotrunkfrom
delete-local-merge
Nov 24, 2021
Merged

[Bug fix] gh pr merge fails to delete remote branch if $PWD is not a git repository#4769
mislav merged 4 commits intotrunkfrom
delete-local-merge

Conversation

@pxrth9
Copy link
Contributor

@pxrth9 pxrth9 commented Nov 19, 2021

Fixes #2833

@pxrth9 pxrth9 requested a review from a team as a code owner November 19, 2021 20:02
@pxrth9 pxrth9 requested review from vilmibm and removed request for a team November 19, 2021 20:02
@pxrth9 pxrth9 changed the title [Bug- Fix] gh pr merge fails to delete remote branch if $PWD is not a git repository [Bug fix] gh pr merge fails to delete remote branch if $PWD is not a git repository Nov 19, 2021
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing work to make this better!

@pxrth9 pxrth9 requested a review from mislav November 23, 2021 21:03
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! looks great

@mislav mislav merged commit 39bd9aa into trunk Nov 24, 2021
@mislav mislav deleted the delete-local-merge branch November 24, 2021 15:50
@VictorBatta VictorBatta mentioned this pull request Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gh pr merge fails to delete remote branch if $PWD is not a git repository

2 participants