Remove the default value from idle-timeout #4756
Merged
Conversation
…t and this can override user settings
Collaborator
|
Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message. |
josebalius
approved these changes
Nov 19, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4741 added
idle-timeoutas a param that could be specified on codespace creation. This works well for those overrides, but users can also set a default timeout in the UI in their codespace settings. This user setting should take precedence over the default 30 minute timeout that happens when the user has no specific value set.With the way it works now, the default value on the new param means that not specifying any idle timeout will always use 30 minutes, which could be very different to the value the user has saved.
The order of precendence is
GH CLI override > codespace settings UI override > VSCS default (30 mins).This change removes the default and omits the value entirely from the API call when not set, which properly falls back to the user's saved setting if available and the 30 min default if the setting is not saved for the user.