Add idle_timeout_minutes as possible cs create param#4741
Merged
Conversation
7e07413 to
03ee9aa
Compare
mislav
reviewed
Nov 17, 2021
Contributor
mislav
left a comment
There was a problem hiding this comment.
This already looks pretty good! Thanks for adding the feature
mislav
approved these changes
Nov 18, 2021
Contributor
mislav
left a comment
There was a problem hiding this comment.
Thank you! 🙇 I have pushed tweaks to take out the -i shorthand (I don't think it's necessary and also I would rather recommend that the idle timeout is always explicitly spelled out), to simplify the implementation slightly, and to add tests.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a friction item for allowing users to specify idle timeout overrides for their codespaces. The plan is to roll out the feature allowing a permanent override via configuration in the UI, while the CLI can optionally specify overrides for each codespace created.
In practice it looks like:
And a few various error cases:
The parameter is bubbled up to the create command which sends this value along to VSCS as the
autoShutdownDelayMinutesenvironment option.To test this flag you must be enabled for https://admin.github.com/devtools/feature_flags/codespaces_custom_idle_timeout otherwise it drops the param and behaves as if it were never passed at all.
Fixes https://github.com/github/cli/issues/101