Conversation
The `codespace code` command used the `skratchdot/open-golang` library to open `vscode://` URLs, which uses `xdg-open` for Linux under the hood, which isn't available under WSL. This switches over to using the `cli/browser` package which has explicit support for WSL by invoking `wslview` when found.
vilmibm
approved these changes
Nov 17, 2021
josebalius
approved these changes
Nov 18, 2021
despreston
pushed a commit
to despreston/cli
that referenced
this pull request
Nov 24, 2021
The `codespace code` command used the `skratchdot/open-golang` library to open `vscode://` URLs, which uses `xdg-open` for Linux under the hood, which isn't available under WSL. This switches over to using the `cli/browser` package which has explicit support for WSL by invoking `wslview` when found.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
codespace codecommand used theskratchdot/open-golanglibrary to openvscode://URLs, which usesxdg-openfor Linux under the hood, which isn't available under WSL.This switches over to using the
cli/browserpackage which has explicit support for WSL by invokingwslviewwhen found. Note that the user's web browser should never actually open, even though we invoke thebrowser.Browse(url)method. Instead, the OS should immediately handlevscode://URLs by opening VS Code directly.Fixes #4709 /cc @mattKorwel