Merged
Conversation
Allows to set multiple secrets from an env file.
gh secret set -f secrets.env
The env file follows a simple format as defined in https://github.com/joho/godotenv
SPAM=eggs
FOO="bar"
- Store multiple secrets in parallel - Perform repo ID resolution in parallel with looking up the encryption key - Avoid resolving repo IDs more than once - Allow passing `--env-file=-` to read from stdin - Fix storing user secrets from file
7b35ed2 to
95a71f7
Compare
mislav
approved these changes
Dec 20, 2021
Contributor
There was a problem hiding this comment.
@lpessoa Awesome! Thanks for your patience.
I've pushed changes to avoid looking up resolving repo names to IDs more than once, to parallelize setting multiple secrets from file so the whole operation finishes faster, to fix setting Codespace secrets (which is a feature that landed to trunk in the meantime), and to simplify tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3579
Allows to set multiple secrets using a simple
.envfile.gh secret set -f secrets.envThe
.envfile follows a simple format as defined in godotenv