Iss 3987 interactive gh create release#4525
Conversation
- Adjust logic in create command to be interactive if no args provided
- Add tests for executing interactive console for create release cmd
- Add new method for running command in CLI using existing samples - Add new method to stub all questions during tests as requested
1dcb51b to
81f1afd
Compare
There was a problem hiding this comment.
@sguzmanm Thanks for the contribution! This is starting to come along nicely. My major reservations about the current approach are it complexity and non-deterministic behavior based on a projects versioning scheme. I left more details in the comments and laid out an alternative approach I think we should take. I would like to hear what my @mislav @vilmibm think so that we can come together on best approach going forward.
|
@samcoe any updates on this pending PR? |
|
@sguzmanm Sorry for the delayed response, after consulting with the team we have landed on going forward with the direction I laid out where we give the user a list of most recent tags and a final option to create a new tag of their choosing. We think this will lead to the most consistent behavior and also mirrors the release create options in the web UI. |
3d54714 to
b448b7d
Compare
e167ebc to
a23e9f3
Compare
|
@samcoe All changes setup, I am having issues running the tests locally since there seems to be an error with some dependencies for GraphQL. If you want you can review this PR meanwhile, and maybe l'll drop an issue for this dependency management bug, cheers :) |
|
Hey @samcoe thx for the help, I have been sick this week, I hope to keep on contributing with you guys in the future |
Creates an interactive command for gh create release that tries to predict the next version of the release if it uses semantic versioning and appends the prerelease text and build number for the current version if needed. So far the terminal looks like this:
Tried to follow the standards in: https://semver.org/
Also this PR adds some unit tests to the "create release" interactive commands since they were missing :/
Fixes #3987