Skip to content

#4386 Enhance create assignee#4420

Merged
samcoe merged 5 commits intocli:trunkfrom
carlqt:enhance-create-assignee
Jan 12, 2022
Merged

#4386 Enhance create assignee#4420
samcoe merged 5 commits intocli:trunkfrom
carlqt:enhance-create-assignee

Conversation

@carlqt
Copy link
Contributor

@carlqt carlqt commented Oct 2, 2021

Issue

#4386

Description

PR to display the Name along with the Username in the list of Assignees

Screenshots

image

@carlqt carlqt changed the title Enhance create assignee #4386 Enhance create assignee Oct 3, 2021
@mislav mislav self-requested a review October 29, 2021 14:05
@mislav mislav self-assigned this Oct 29, 2021
@mislav mislav added the external pull request originating outside of the CLI core team label Dec 20, 2021
@vilmibm vilmibm assigned samcoe and unassigned mislav Jan 10, 2022
@vilmibm vilmibm requested a review from samcoe January 10, 2022 17:09
@carlqt carlqt requested a review from a team as a code owner January 12, 2022 08:38
samcoe
samcoe approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlqt Thanks for the contribution. I pushed a small change so that when we actually submit assignees and reviewers to GitHub we only send the users login and not the whole display name which is what is required by the API.

@samcoe samcoe enabled auto-merge (squash) January 12, 2022 08:48
@samcoe samcoe merged commit ad8d7bb into cli:trunk Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mislav mislav Awaiting requested review from mislav

1 more reviewer

@samcoe samcoe samcoe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@samcoe samcoe

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlqt @samcoe @mislav