#4258 Add sub command to delete asset from release#4416
Merged
Conversation
|
Helpful fore
…On Sat, Oct 2, 2021, 9:06 AM Adarsh K Kumar ***@***.***> wrote:
Fixes #4258 <#4258> add a sub command to
delete assets
------------------------------
You can view, comment on, or merge this pull request online at:
#4416
Commit Summary
- #4258 Add sub command to delete asset from release
<9d392ec>
File Changes
- *A* pkg/cmd/release/delete-asset/delete_asset.go
<https://github.com/cli/cli/pull/4416/files#diff-5e88f2bd8148b16ba17afd5fe61439d5d8272f0374da68de8a7ebf6c6c455f22>
(127)
- *A* pkg/cmd/release/delete-asset/delete_asset_test.go
<https://github.com/cli/cli/pull/4416/files#diff-5264145e98cbe72843460c3810e2f0ddf23f6c3d6f96b0d9b1079a2c2c80221b>
(167)
- *M* pkg/cmd/release/release.go
<https://github.com/cli/cli/pull/4416/files#diff-6b8a5bb9b784497362eca14c1f55a3a2ccd4dd2e48c8cb7083e26bb115785dd2>
(2)
Patch Links:
- https://github.com/cli/cli/pull/4416.patch
- https://github.com/cli/cli/pull/4416.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4416>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVXVWOGTOXTIGAICKH24MILUE37WJANCNFSM5FGMMP6Q>
.
|
m4ver1k
commented
Oct 3, 2021
| @@ -0,0 +1,127 @@ | |||
| package deleteasset | |||
Contributor
Author
There was a problem hiding this comment.
i'm not so happy with this package name 😓
Contributor
Author
|
@mislav can you please take a look at this PR ? |
|
any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4258 add a sub command to delete assets