Skip to content

Add repository deploy key operations support#4302

Merged
mislav merged 7 commits intocli:trunkfrom
n1lesh:repo-deploy-keys
Jan 25, 2022
Merged

Add repository deploy key operations support#4302
mislav merged 7 commits intocli:trunkfrom
n1lesh:repo-deploy-keys

Conversation

@n1lesh
Copy link
Contributor

@n1lesh n1lesh commented Sep 9, 2021

Fixes #4242

@samcoe samcoe requested review from a team and samcoe and removed request for a team September 9, 2021 19:47
@samcoe samcoe self-assigned this Sep 9, 2021
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and this works and looks great! Just raising a number of usability & UI concerns

$ gh repo create
$ gh repo clone cli/cli
$ gh repo view --web
$ gh repo deploy-key list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this example. Not everyone uses deploy keys and we don't have to necessarily show off every gh repo subcommand in these examples.

@mislav mislav added the external pull request originating outside of the CLI core team label Dec 20, 2021
@n1lesh n1lesh requested a review from a team as a code owner January 25, 2022 17:33
@mislav
Copy link
Contributor

mislav commented Jan 25, 2022

I have:

  • addressed my previous code review
  • simplified and corrected some tests
  • removed the bits about manually verifying OAuth scopes, since that's no longer necessary in our codebase
  • remove the interactive confirm bit from deploy-key delete
  • simplified the implementation
  • added some docs

@mislav mislav enabled auto-merge (squash) January 25, 2022 17:41
@mislav mislav merged commit 47a6aff into cli:trunk Jan 25, 2022
)

type AddOptions struct {
IO *iostreams.IOStreams

This comment was marked as spam.

Copy link

@NikkeiNiceNicole NikkeiNiceNicole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for deploy key operations

6 participants