Skip to content

Fixes #4084: Enable completion descriptions for powershell#4085

Merged
mislav merged 1 commit intocli:trunkfrom
marckhouzam:feat/compPowershell
Aug 4, 2021
Merged

Fixes #4084: Enable completion descriptions for powershell#4085
mislav merged 1 commit intocli:trunkfrom
marckhouzam:feat/compPowershell

Conversation

@marckhouzam
Copy link
Contributor

@marckhouzam marckhouzam commented Aug 4, 2021

Fixes #4084
Since completion descriptions are automatically enabled for all other shells, this PR simply calls the proper API to enable them for Powershell. This yields:

PS /Users/marckhouzam/git/cli> bin/gh <TAB>
actions     (Learn about working with GitHub actions)         issue       (Manage issues)
alias       (Create command shortcuts)                        pr          (Manage pull requests)
api         (Make an authenticated GitHub API request)        release     (Manage GitHub releases)
auth        (Login, logout, and refresh your authentication)  repo        (Create, clone, fork, and view repositories)
browse      (Open the repository in the browser)              run         (View details about workflow runs)
completion  (Generate shell completion scripts)               secret      (Manage GitHub secrets)
config      (Manage configuration for gh)                     ssh-key     (Manage SSH keys)
gist        (Manage gists)                                    workflow    (View details about GitHub Actions workflows)
help        (Help about any command)                          co

See https://github.com/spf13/cobra/blob/master/shell_completions.md#powershell-completions

@marckhouzam
Enable completion descriptions for powershell
549caf2 
Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
mislav
mislav approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thank you!

@mislav mislav enabled auto-merge August 4, 2021 13:09
@mislav mislav merged commit fddca21 into cli:trunk Aug 4, 2021
@marckhouzam marckhouzam deleted the feat/compPowershell branch August 4, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mislav mislav mislav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Powershell completion does not include descriptions

2 participants

@marckhouzam @mislav