Skip to content

Fix setting environment secrets#3832

Merged
mislav merged 1 commit intotrunkfrom
env-set-fix
Jun 14, 2021
Merged

Fix setting environment secrets#3832
mislav merged 1 commit intotrunkfrom
env-set-fix

Conversation

@mislav
Copy link
Contributor

@mislav mislav commented Jun 14, 2021

This uses the correct public key when setting environment secrets.
https://docs.github.com/en/rest/reference/actions#get-an-environment-public-key

Fixes #3831

Copy link
Contributor

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch, didn't realised that the secret should be pulled from somewhere else 🤦🏻

Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@mislav mislav merged commit 5984cf2 into trunk Jun 14, 2021
@mislav mislav deleted the env-set-fix branch June 14, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting environment secrets results in an invalid secret value

3 participants