Skip to content

Include issue number alongside the title in gh issue/pr view#3741

Merged
vilmibm merged 5 commits intocli:trunkfrom
Jackenmen:patch-1
Jun 2, 2021
Merged

Include issue number alongside the title in gh issue/pr view#3741
vilmibm merged 5 commits intocli:trunkfrom
Jackenmen:patch-1

Conversation

@Jackenmen
Copy link
Contributor

Should fix #3729

@Jackenmen Jackenmen changed the title Update formatting Include PR number alongside the title in gh pr view May 29, 2021
@Jackenmen
Copy link
Contributor Author

Jackenmen commented May 29, 2021

I just realized I forgot about gh issue view, should I include such a change in this PR as well?

Edit: went ahead and did that, let me know if you want me to split it into another PR as it should just a matter of cherry-picking because each individual commit should work properly on its own.

@Jackenmen Jackenmen changed the title Include PR number alongside the title in gh pr view Include PR number alongside the title in gh issue/pr view May 29, 2021
@Jackenmen Jackenmen changed the title Include PR number alongside the title in gh issue/pr view Include issue number alongside the title in gh issue/pr view May 29, 2021
@vilmibm vilmibm self-requested a review June 1, 2021 20:43
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! just gotta fix that missing newline

Copy link
Contributor Author

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this comment, just preparing the code suggestions to merge into the PR's branch.

@Jackenmen
Copy link
Contributor Author

I've noticed that there were some conflicts so I resolved them too. This should be ready to go now.

Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, thank you~

@vilmibm vilmibm merged commit a1cedfc into cli:trunk Jun 2, 2021
@Jackenmen Jackenmen deleted the patch-1 branch June 2, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include PR number at the top of gh pr view's output

2 participants