Conversation
mislav
reviewed
May 26, 2021
internal/config/config_file.go
Outdated
| if path := os.Getenv(XDG_STATE_HOME); path != "" { | ||
| path = filepath.Join(path, "gh") | ||
| if _, err := os.Stat(path); errors.Is(err, os.ErrNotExist) { | ||
| _ = os.MkdirAll(path, 0755) |
Contributor
There was a problem hiding this comment.
This MkdirAll doesn't look like it's necessary here
Contributor
Author
There was a problem hiding this comment.
Originally I didn't have it in there, but in the scenario where XDG_STATE_HOME is specified and there is no previous state.yml file then XDG_STATE_HOME/gh does not get created and the code that writes the state file does not create the directory so writing the state file will fail.
mislav
approved these changes
May 27, 2021
internal/config/config_file.go
Outdated
| if path := os.Getenv(XDG_STATE_HOME); path != "" { | ||
| path = filepath.Join(path, "gh") | ||
| if !dirExists(path) { | ||
| _ = os.MkdirAll(path, 0755) |
Contributor
There was a problem hiding this comment.
Is this mkdir necessary since migrateFile does it internally? It feels weird that just reading StateDir creates a filesystem entry even if no migration is happening
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
XDG_STATE_HOMEenvironment variable. If present we will store thestate.ymlfile at the path provided, if one already exists in the old config location we will try to migrate it to the new path. If the environment variable is not present then behavior will remain the same and the config directory will continue to be used to storestate.yml.cc #2470
cc #554