Conversation
Contributor
Author
|
This doesn't work with Not sure what the fix would be. |
Contributor
|
The commit I added fixes reprepro ( https://github.com/cli/cli/runs/2604521655?check_suite_focus=true ). AFAIK this is all we have to do to add new codenames (and to test it, here is a PR reflecting the changes the next release should make: https://github.com/github/cli.github.com/pull/40 ). |
vilmibm
approved these changes
May 17, 2021
Contributor
vilmibm
left a comment
There was a problem hiding this comment.
approving this so mislav has the option of merging in his AM
samcoe
approved these changes
May 17, 2021
Contributor
Author
|
Thanks @vilmibm; I was totally unaware of that additional file! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3398, fixes #1798