Conversation
|
@mislav thanks a lot for taking the time to cleanup as well as leave the review comments. I'm sure it would help me in the future❤️🙏 |
samcoe
left a comment
There was a problem hiding this comment.
The code looks good to me. One question, are there any new error states that arise from organization permissions that we need to handle on our end? I expect that if the user does not have permission to create a repo inside the organization the API will return an unauthorized error.
@samcoe we needn't handle any more error states, the API returns a 401 directly to the console via the usual error handling with the message |
|
@samcoe: @g14a actually added more specialized error handling, but I've removed it for the sake of simplicity and trusting that the backend will respond with a descriptive enough error. If that proves not to be the case, I suggest that we make a followup change in the future, but right now it feels early. |
Fixes #1247
Supersedes #3608