Add validation to gists if contents are empty#3578
Merged
Conversation
mislav
suggested changes
May 4, 2021
Contributor
Author
|
Thank you for the quick feedback @mislav :) Updated the PR |
aumra
approved these changes
May 4, 2021
7df3c2d to
2fc2723
Compare
2fc2723 to
70a9621
Compare
mislav
approved these changes
May 7, 2021
Contributor
mislav
left a comment
There was a problem hiding this comment.
Fantastic; thank you!
Added some minor cleanups.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a validation whether or not gist contents are empty. If they are, throws an error for the same.
Fixes #3481