catch mintty error and add help for it#3537
Merged
Conversation
mislav
approved these changes
Apr 29, 2021
Contributor
mislav
left a comment
There was a problem hiding this comment.
This is great. Thank you!
pkg/cmd/root/help_topic.go
Outdated
| Be sure to check the box "Enable experimental support for pseudo consoles". | ||
|
|
||
| - Use a different terminal emulator with Git for Windows like Windows Terminal or cmd.exe. | ||
| Try running "C:\Program Files\Git\bin\bash.exe" in one of those other terminal emulators. |
Contributor
There was a problem hiding this comment.
Hmm, is this really the only way to consistently open Git Bash from Windows Terminal? Isn't there some way to create a shortcut of some kind so that people don't have to type or paste the full path?
Contributor
Author
There was a problem hiding this comment.
You can set up a Windows Terminal profile to always run bash.exe, set up a shortcut, or add to PATH but all of those strategies seemed out of scope for this help topic.
added 2 commits
April 29, 2021 16:01
This reverts commit 15c16bd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR notices when MinTTY fails to gather input with "Incorrect function" and then suggests the user run "gh help mintty" to learn about workarounds.
I've tested each workaround (including running git+bash via Windows Terminal) on my Windows machine.
Ref. #404