Conversation
mislav
approved these changes
Apr 28, 2021
| if err != nil { | ||
| return nil, err | ||
| } | ||
| fmt.Fprintln(opts.IO.Out) |
Contributor
There was a problem hiding this comment.
Doesn't Survey take care of printing the newline after the prompt?
Contributor
Author
There was a problem hiding this comment.
usually yes, but i was seeing bizarre behavior with the password prompt. It printed a newline and then some tab characters and then output continued after the tabs. Manually printing a new line fixed it 🤷
samcoe
approved these changes
Apr 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR augments
gh secret setto prompt in the event that no secret body is provided. This case was formerly an error, so I don't think it qualifies as a breaking change.This closes a gap in
secret setI've been meaning to get to since it initially released. Originally I had a whole interactive wizard for this, but realized all anyone really wants is the ability to paste a secret body (instead of putting it in a file).Before:
After:
Using STDIN still works as before (
gh secret set foo < secret.txt).There's no issue for this (I think), it's just been taking up space in my mental TODO list for months.