Optionally read stdin for gh alias set#3490
Merged
Conversation
vilmibm
suggested changes
Apr 23, 2021
Contributor
vilmibm
left a comment
There was a problem hiding this comment.
This is great, thank you!
I would prefer that this trigger on -, though, as you originally suggested. While there's prior art in secret set I actually think secret set needs to change since we'd like it to prompt by default (and then have a flag for reading from STDIN).
Contributor
Author
|
I admit I also like how explicit |
Contributor
Author
|
While I'm at it, do you want me to change (or at least add |
Resolves PR feedback.
Contributor
|
@heaths thanks for the offer, but no worries. I've gone and tweaked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3487