Merged
Conversation
mislav
approved these changes
Apr 12, 2021
Contributor
There was a problem hiding this comment.
Thank you!
I do not think that this is an embedded struct. Instead, what I think is happening is that the unused linter considers any exported type or field to be potentially used (even if it's not used from our own codebase). Since everything about api.PullRequest.HeadRepository.DefaultBranchRef is exported, it is not checked by unused linter. We probably have a lot more exported structs/fields/methods that are dead code; i.e. unused in our own codebase.
I wish that there was a version of unused that also checks exported identifiers, but alas, I did not find one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes an unused embedded struct declared in
type PullRequest struct.It looks like the linter used by
golangci-lintto found unused struct fields doesn't handle embedded structs yet.