Add run download command for fetching workflow artifacts
#3349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilmibm
reviewed
Apr 2, 2021
Contributor
vilmibm
left a comment
There was a problem hiding this comment.
I'm mostly happy with the usability and direction of this! I otherwise just have questions around testing and code organization.
pkg/cmd/run/view/view.go
Outdated
| "github.com/cli/cli/api" | ||
| "github.com/cli/cli/internal/ghinstance" | ||
| "github.com/cli/cli/internal/ghrepo" | ||
| "github.com/cli/cli/pkg/cmd/run/download" |
Contributor
There was a problem hiding this comment.
Should this dependency be done via a shared package instead of a direct subcommand dependency?
| reg.Register( | ||
| httpmock.REST("GET", "repos/OWNER/REPO/actions/runs/3"), | ||
| httpmock.JSONResponse(shared.SuccessfulRun)) | ||
| reg.Register( |
Contributor
There was a problem hiding this comment.
seems worth testing the artifact printing in at least one case
- With no arguments in TTY mode, prompt which artifacts to download - Change `--pattern` argument to be just `--name` and only do exact matching - For multi-archive downloads, prefix the destination path with the name of the artifact - Add tests exercising HTTP functionality - Avoid "zipslip" path injection when extracting ZIP files - Add tests for ZIP extraction
78a7a6b to
026dc46
Compare
vilmibm
approved these changes
Apr 7, 2021
Contributor
vilmibm
left a comment
There was a problem hiding this comment.
Tiniest nitpick about Examples and it needs a fix for the Windows tests but otherwise this is great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloading artifacts per run:
gh run download 123-pflagDownloading artifacts per repository:
gh run download -p name1 -p name2No arguments = error. Should we display some kind of selector in this case? If so, what should the options in the selector be?
Inspirations:
gh release downloadTODO:
Fixes #3321