Suggest brew upgrade gh when new version detected#2929
Merged
Conversation
When the update notifier is enabled and a new version was detected, show a Homebrew upgrade notice if: - the release was at least 24 hours ago; and - the current `gh` binary is under the Homebrew prefix.
samcoe
reviewed
Feb 9, 2021
| return false | ||
| } | ||
|
|
||
| brewBinPrefix := filepath.Join(strings.TrimSpace(string(brewPrefixBytes)), "bin") + string(filepath.Separator) |
Contributor
There was a problem hiding this comment.
TIL filepath.Separator exists.
mislav
added a commit
to mislav/homebrew-core
that referenced
this pull request
Feb 10, 2021
BrewTestBot
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Feb 10, 2021
Ref. cli/cli#2929 Closes #70784. Signed-off-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the update notifier is enabled and a new version was detected, show a Homebrew upgrade notice if:
ghbinary is under the Homebrew prefix.Followup TODO:
Fixes #2855, ref. #166