Skip to content

Display output of build commands.#2926

Merged
mislav merged 1 commit intotrunkfrom
unknown repository
Feb 6, 2021
Merged

Display output of build commands.#2926
mislav merged 1 commit intotrunkfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Feb 6, 2021

Print out output of executed build command to stdout/stderr.

Summary

closes #2920

Details

Before:

$ make
go build -o script/build script/build.go
go build -trimpath -ldflags "-X github.com/cli/cli/internal/build.Date=2021-02-06 -X github.com/cli/cli/internal/build.Version=v1.6.0-pre.3-38-g092cc4c4 " -o bin/gh ./cmd/gh
exit status 1
build.go: building task `bin/gh` failed.
make: *** [Makefile:12: bin/gh] Error 1

After:

$ make
go build -o script/build script/build.go
go build -trimpath -ldflags "-X github.com/cli/cli/internal/build.Date=2021-02-06 -X github.com/cli/cli/internal/build.Version=v1.6.0-pre.3-39-g9920ea97 " -o bin/gh ./cmd/gh
context/context.go:7:4: expected 'STRING', found newline
exit status 1
build.go: building task `bin/gh` failed.
make: *** [Makefile:12: bin/gh] Error 1

This fixes #2920.

Print out output of executed command to stdout/stderr.
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. Thank you!

@mislav mislav merged commit f43fb26 into cli:trunk Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build script doesn't show build errors

1 participant