Conversation
2b53466 to
52bdcad
Compare
mislav
approved these changes
Jan 27, 2021
| } | ||
|
|
||
| if opts.Comments { | ||
| fmt.Fprint(opts.IO.Out, shared.RawCommentList(pr.Comments, pr.Reviews)) |
vilmibm
approved these changes
Jan 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
pr viewandissue viewto no longer display minimized comments, instead they now show small headers indicating why a comment has been minimized.After chatting with @ampinsk we decided that the minimized headers should be white, not gray, as the original design proposed.
closes #2847